Hi Thomas

Do you have some code that could be shared? And how does the user pick a city/article? Perhaps the issue happens because one of the children looped over does not have an id picked.

/Jan

Following is the function which is called from the macroscript CityRenderer.cshtml

public static List<Node> GetThingsToDo(int cityId, int amount = 0)
    {
        List<Node> foundNodes = GetAllCityReferences(cityId, "DESTINATIONS - THINGS TO DO", 4232);
        if (null != foundNodes && foundNodes.Count() > 0)
        {
            return foundNodes.OrderBy(m => m.GetProperty("title").Value).ToList();
        }
        else
            return new List<Node>();
    }

This function calls as you can see the GetAllCityReferences function which is the following:

private static List<Node> GetAllCityReferences(int cityId, string nodeName, int parentNodeId = 0, int amount = 0)
    {
        List<Node> foundNodes = new List<Node>();

        Node parentNode = null;
        if (parentNodeId == 0)
        {
            parentNode = umbraco.uQuery.GetNodesByName(nodeName).SingleOrDefault();
        }
        else
        {
            parentNode = new Node(parentNodeId);
        }

        if (null != parentNode)
        {
            foundNodes = GetAllNodesByType(parentNode.Id, "travelDestinationType", cityId);
        }

        if (amount > 0 && null != foundNodes && foundNodes.Count() > 2)
            return foundNodes.OrderByDescending(f => f.UpdateDate).Take(amount).ToList();

        if (null != foundNodes)
            return foundNodes;
        else
            return new List<Node>();
    }

And from this function starts the recursive mode:

private static List<Node> GetAllNodesByType(int NodeId, string typeName, int cityId)
    {
        List<Node> foundNodes = new List<Node>();
        var node = new Node(NodeId);

        foreach (Node childNode in node.Children)
        {
            var child = childNode;
            if (child.NodeTypeAlias == typeName)
            {
                try
                {
                    if (child.HasProperty("city") && child.GetProperty("city") != null)
                    {
                        var city = child.GetProperty("city").Value;
                        if (null != city)
                        {
                            string[] arr = city.Split(',');
                            if (null != arr && arr[arr.Length - 1].InvariantEquals(cityId.ToString()))
                            {
                                foundNodes.Add(child);
                            }
                        }
                    }
                }
                catch (Exception ex)
                {
                    string ss = ex.Message;
                }
            }

            if (child.Children.Count > 0)
                GetAllNodesByType(ref foundNodes, child, typeName, cityId);
        }

        return foundNodes.OrderByDescending(m => m.UpdateDate).ToList();
    }

This code is working for at least one year. I believe that the OutOfMemory has to do with the memory leaks of the MailEnable Server (which have memory leaks) but i need a suggestion if there is a better way to try and get the results instead of doing the recursive model.

Regards

Thomas

is working on a reply...