Hi everybody.

I'm packaging up uForum (for Umbraco 4.1RC), and I would like some input on how the package actions work with regard to uninstalling.

I too a look at the source, and it seems a bit unclear how I would make sure that an action has the undo method called when the package is uninstalled?

The 4.1RC core seems to have this code:

//Package Actions
foreach (XmlNode n in _packageConfig.DocumentElement.SelectNodes("Actions/Action")) {

    if (n.Attributes["undo"] == null || n.Attributes["undo"].Value == "false") {
        insPack.Data.Actions += n.OuterXml;
        Log.Add(LogTypes.Debug, -1, HttpUtility.HtmlEncode(n.OuterXml));
    }

    if (n.Attributes["runat"] != null && n.Attributes["runat"].Value == "install") {
        try {
            packager.PackageAction.RunPackageAction(insPack.Data.Name, n.Attributes["alias"].Value, n);
        } catch {

        }
    }
}

It looks to me as, if I set the "undo" attribute to true, then the action is not saved for uninstalling. But if I set it to "false" or don't set it at all, then it _will_ be saved for uninstallation.

So the correct action at this point is to not set it at all. Is that correct?