Hi there,

A natural progression of working with Umbraco for us is now building super flexible (and hopefully smart!) XSLT macro's which mean we can roll out developments faster. This works around the fact we use grids for our projects.

It all works nicely, however I was wondering if anyone had any idea's on how to refactor this code.

Look at the $ModuleWidth and get the correct grid for it.

--

The first code snippet is how in a weird Laurence world this would work, (but can't!)

Get the value of $grid_(x)

Where x = $moduleWidth (which is an integer)

<img>
    <xsl:attribute name="src">
        <xsl:text>/umbraco/ImageGen.ashx?image=</xsl:text>
        <xsl:value-of select="umbraco.library:GetMedia($media,'1')/data [@alias = 'mediaCrops']//crop[@name = 'Portrait']/@url"/>
        <!-- This code needs refactoring -->
        <xsl:text>&amp;width=</xsl:text>
      <xsl:value-of select="$grid_$moduleWidth"/>

This is the code which does however work;

<img>
    <xsl:attribute name="src">
        <xsl:text>/umbraco/ImageGen.ashx?image=</xsl:text>
        <xsl:value-of select="umbraco.library:GetMedia($media,'1')/data [@alias = 'mediaCrops']//crop[@name = 'Portrait']/@url"/>
        <!-- This code needs refactoring -->
        <xsl:text>&amp;width=</xsl:text>
        <xsl:choose>
            <xsl:when test="$moduleWidth = 1">
                <xsl:value-of select="$grid_1" />
            </xsl:when>
            <xsl:when test="$moduleWidth = 2">
                <xsl:value-of select="$grid_2" />
            </xsl:when>
            <xsl:when test="$moduleWidth = 3">
                <xsl:value-of select="$grid_3" />
            </xsl:when>
            <xsl:when test="$moduleWidth = 4">
                <xsl:value-of select="$grid_4" />
            </xsl:when>
            <xsl:when test="$moduleWidth = 5">
                <xsl:value-of select="$grid_5" />
            </xsl:when>
            <xsl:when test="$moduleWidth = 6">
                <xsl:value-of select="$grid_6" />
            </xsl:when>
            <xsl:when test="$moduleWidth = 7">
                <xsl:value-of select="$grid_7" />
            </xsl:when>
            <xsl:when test="$moduleWidth = 8">
                <xsl:value-of select="$grid_8" />
            </xsl:when>
            <xsl:otherwise></xsl:otherwise>
        </xsl:choose>
    </xsl:attribute>
    <xsl:attribute name="alt">
        <xsl:value-of select="@nodeName"/>
    </xsl:attribute>
</img>

Thanks in advance!

Hope this isn't a dumb problem, but more of an interesting one! It's getting me thinking! Laurie