Copied to clipboard

Flag this post as spam?

This post will be reported to the moderators as potential spam to be looked at


  • Piotr 5 posts 75 karma points
    Jan 21, 2020 @ 15:35
    Piotr
    0

    Seo checker title

    Hi,

    We have configured Title template as [#@seoTitle] | someText and Default title properties @nodeName. In Razor view we have .

    Let's say we have 3 pages : Home, Contact and About us. This settings works on Home page it shows Home | someText, but when we go to contact page we also get Home | someText. Should we use some method to get this title from seo checker?

    Also I have noticed that when we hijack action in Controller (from Umbraco flow) we get there already a wrong value. Does Seochecker have some caching machanism?

    We are using Umbraco 8.4 and SeoChecker 2.9.0

    Best regards, Piotr

  • Richard Soeteman 3875 posts 12037 karma points MVP
    Jan 22, 2020 @ 07:55
    Richard Soeteman
    0

    Hi,

    How do you render the page. Snippet should be

    @{
    var seo = Model.Value("sEOPreview") as SEOChecker.MVC.MetaData;
     }
    
    @seo.AllTags
    

    There is caching but only on the current page.

    Best,

    Richard

  • Piotr 5 posts 75 karma points
    Jan 22, 2020 @ 08:07
    Piotr
    0

    Hello,

    Thanks for your reply. I have pasted this snippet to my code and unfortunately I still get wrong title, it doesn't refresh when navigating to other pages.

    We are using inheritance for every page from PageBase (when we put seoChecker components). Should we add it separately to every page or it doesn't matter?

    Best regards,

    Piotr

  • Richard Soeteman 3875 posts 12037 karma points MVP
    Jan 22, 2020 @ 08:09
    Richard Soeteman
    0

    I retreive from a composition and master layout as well. In the backoffice snippet you see the correct values?

  • Piotr 5 posts 75 karma points
    Jan 22, 2020 @ 08:14
    Piotr
    0

    For most pages yes, I have correct values, for the rest I get "The default SEO title properties will be used after first save. /new-document " after saving document it looks ok.

  • Richard Soeteman 3875 posts 12037 karma points MVP
    Jan 22, 2020 @ 08:18
    Richard Soeteman
    0

    The last is normal on creation or when SEOChecker is added after page creation. But the I am very curious what is happening since the code snippet above is based on this property editor. Would it be possible to share the environment maybe so I can run in debug mode and see what is either wrong in your setup or our code? I delete the environment afterwards. When possible please mail [email protected].

    Best,

    Richard

  • Michael Chart 13 posts 94 karma points
    Mar 20, 2020 @ 14:24
    Michael Chart
    0

    Hi Richard,

    We are also seeing this issue. I've attached a few screenshots that hopefully help illustrate the issue.

    SEO Checker doc type settings - we are using a HasSEO composition that the Home Page and Contact Us Page doc types inherit from. SEO Checker doc type settings

    Home page CMS content: Home page CMS properties

    Contact us CMS content: Contact us CMS properties

    Then we load the homepage:

    Home page title

    And then load the contact us page: Contact us page title

    As you can see the contact us page is using the Home page title. Definitely seems like some kind of caching issue.

    When loading the Contact Us page and debugging the SeoMetadata property, it shows the data for the homepage:

    Debugging contact us page

    Let me know if you need any more info to diagnose the issue.

  • Michael Chart 13 posts 94 karma points
    Mar 27, 2020 @ 10:29
    Michael Chart
    0

    Sorry to hassle Richard - is this something you might be able to look at soon?

  • Richard Soeteman 3875 posts 12037 karma points MVP
    Mar 27, 2020 @ 10:34
    Richard Soeteman
    1

    Could it be related to $ sign The normal otpions is exactly what I have in my test environment without any caching. This is on the list of things to check for 2.10. Scheduled for April .

    Sorry for the delay.

    Best,

    Richard

  • Michael Chart 13 posts 94 karma points
    May 01, 2020 @ 12:50
    Michael Chart
    0

    Hi Richard,

    Any update on how the next release is coming on?

    Sorry to hassle!

    Thanks,

    Mike

  • Richard Soeteman 3875 posts 12037 karma points MVP
    May 04, 2020 @ 05:16
    Richard Soeteman
    0

    I hope this month, sorry for the delay

  • Shams Mehra 2 posts 71 karma points
    May 04, 2020 @ 12:54
    Shams Mehra
    0

    It's similar to Lighthouse and other tools but worth a look. It's way too top-level to be of any use for sites as large as the one I work on, but a fun 5mins if you are a nerd like me. May be useful to beginners on here.

    Regards. .

  • Thomas 212 posts 480 karma points c-trib
    May 12, 2020 @ 15:27
    Thomas
    0

    I have an issue with one of my projects. It pulls the wrong title and description on the root node ?

    It's only one of my projects... The all share the same code base..

  • Richard Soeteman 3875 posts 12037 karma points MVP
    May 13, 2020 @ 06:09
    Richard Soeteman
    0

    How did you configure it on that site?

  • Thomas 212 posts 480 karma points c-trib
    May 13, 2020 @ 10:54
    Thomas
    0

    Hey

    ... It's weird, but it seams to work now...


    All the nodes have a the same compasition with a seo tab.

    This is on the doctype for the frontpage where it don't work.

    enter image description here

    Local: here it works... enter image description here

  • Thomas 212 posts 480 karma points c-trib
    May 14, 2020 @ 07:25
    Thomas
    0

    hmm now it's wrong again...

    If you look at the title at https://www.naestved.dk/ the title and description comes from the 404 page... ?

  • Richard Soeteman 3875 posts 12037 karma points MVP
    May 14, 2020 @ 07:27
    Richard Soeteman
    0

    How do you render the meta data?

  • Thomas 212 posts 480 karma points c-trib
    May 20, 2020 @ 09:04
    Thomas
    0

    Hey Richard

    In my head partial I have:

    var seoData = Umbraco.AssignedContentItem.Value<SEOChecker.MVC.MetaData>("seoChecker");
    

    and then

    <meta property="og:title" content="@(seoData.Title)" />
    <meta property="og:description" content="@(seoData.Description)" />
    
  • Richard Soeteman 3875 posts 12037 karma points MVP
    May 20, 2020 @ 09:23
    Richard Soeteman
    0

    That looks okay and works for me is it always generating the 404 page?

  • Thomas 212 posts 480 karma points c-trib
    May 20, 2020 @ 09:51
    Thomas
    0

    Hey

    yes. Looks like it's always the 404, that the text are coming from.. But it's only on the root node.. All the other nodes are fine..

  • Richard Soeteman 3875 posts 12037 karma points MVP
    May 22, 2020 @ 06:52
    Richard Soeteman
    0

    Must be that the status of the page is also 404 then?

  • Thomas 212 posts 480 karma points c-trib
    May 27, 2020 @ 08:46
    Thomas
    0

    Sorry for the late response..

    It's really wierd..

    On my frontpage - the only template where the meta title/ description are wrong.. sometimes.

    If you see here on https://baseline.cabana.local/ it's gives me https://baseline.cabana.local/side-for-abonneter for url and Seotitle and description for that page. enter image description here

    But if I publish the frontpage again it gives me the correct data... enter image description here

    But after som times when I publish it again I takes data from a diffrent node..

  • Richard Soeteman 3875 posts 12037 karma points MVP
    May 27, 2020 @ 12:32
    Richard Soeteman
    0

    My assumption is that AssignedContentItem is not correct all the time

    What happens when you use

    @{
     var seo = Model.Value("seoChecker") as SEOChecker.MVC.MetaData;
       }
    
     @seo.AllTags
    
  • Thomas 212 posts 480 karma points c-trib
    May 28, 2020 @ 07:42
    Thomas
    0

    I will try. I have tried with

           Model.Value<SEOChecker.MVC.MetaData>("seoChecker");
    

    And that did the same..

    The problem is that it's not always. When I publish the frontpage it works for some time and the it fallback to a randow page again..

  • Michael Chart 13 posts 94 karma points
    Jun 04, 2020 @ 11:39
    Michael Chart
    0

    It seems to work correctly using

    var metadata = new MetaData(new SEOChecker.Library.MetaData(Model.Id, Culture));

    rather than using the model property. Presumably this bypasses the caching that's causing this bug?

  • Johan Reitsma 44 posts 179 karma points
    Jun 09, 2020 @ 09:57
    Johan Reitsma
    0

    I'm also having this issue. Also keywords is empty :(

  • Michael Chart 13 posts 94 karma points
    Jun 19, 2020 @ 15:38
    Michael Chart
    0

    Hi Richard,

    Just wondered if there's anything we can do to help you track down the cause of this issue. The issue we're experiencing is the one I described here: https://our.umbraco.com/packages/website-utilities/seo-checker/bugs/100772-seo-checker-title#comment-317986. The metadata for one node seems to get cached and used on every page after this point.

    At the moment we've resorted to this: https://our.umbraco.com/packages/website-utilities/seo-checker/bugs/100772-seo-checker-title#comment-320375, but this makes a number of SQL queries, so is pretty bad for performance.

    We'd really like to get to the bottom of this. Is there anything we can do to help?

    Kind regards,

    Mike

  • Richard Soeteman 3875 posts 12037 karma points MVP
    Jun 22, 2020 @ 06:46
    Richard Soeteman
    0

    If there is anything cached then it's in the PropertyValueConverter. But since you don't use that as well and it's always displaying the 404 page metadata i think it's related to something throwing a 404?

  • Michael Chart 13 posts 94 karma points
    Jun 22, 2020 @ 08:01
    Michael Chart
    0

    Hi Richard,

    For us, it's not the 404 page metadata that shows, it seems to be the first page that's loaded after a recycle. It does sound like the issue is related to the property value converter as the issue doesn't occur when we avoid the property value converter.

    The issue is described in more detail in my comment here: https://our.umbraco.com/packages/website-utilities/seo-checker/bugs/100772-seo-checker-title#comment-317986

    Kind regards,

    Mike

  • Richard Soeteman 3875 posts 12037 karma points MVP
    Jun 22, 2020 @ 08:04
    Richard Soeteman
    0

    I think I will remove the Property value converter in that case. SEOChecker needs context of the page.

  • Michael Chart 13 posts 94 karma points
    Jun 22, 2020 @ 08:10
    Michael Chart
    0

    I see, yes that makes sense.

    Will we still be able to make use of some kind of caching to avoid hitting the database? When we resorted to doing this:

    var metadata = new MetaData(new SEOChecker.Library.MetaData(Model.Id, Culture));

    we found that there were about 12 SQL queries when loading the page.

  • Richard Soeteman 3875 posts 12037 karma points MVP
    Jun 22, 2020 @ 08:14
    Richard Soeteman
    0

    That is used for Internal use

    If you use this, it is using the Umbraco published document

    @{
    var seo = Model.Value("your seo property here") as    SEOChecker.MVC.MetaData;
       }
    
    @seo.AllTags
    
  • Michael Chart 13 posts 94 karma points
    Jun 22, 2020 @ 08:47
    Michael Chart
    0

    Even using this approach:

    var seo = Model.Value("your seo property here") as    SEOChecker.MVC.MetaData;
    
    @seo.AllTags
    

    We're still seeing a caching issue. For some pages the metadata is fine. But for other pages, they show metadata for a previously visited page.

    Kind regards,

    Mike

  • Richard Soeteman 3875 posts 12037 karma points MVP
    Sep 01, 2020 @ 14:20
    Richard Soeteman
    0

    Hi Michael,

    I think I found the issue. https://github.com/umbraco/Umbraco-CMS/issues/8347 Will see what I can do to have a working solution in SEOChecker as well since you ideally want to have a property editor converter.

    Best,

    Richard

  • Richard Soeteman 3875 posts 12037 karma points MVP
    Sep 07, 2020 @ 07:31
    Richard Soeteman
    0

    Hi All,

    I think I have fixed this issue now. Was a combination of bug above and something really stupid I did.

    I have created a Hotfix for this which will also be included in the new 2.10 version of SEOChecker

    Sorry for the hassle and hope this helps,

    Richard

  • This forum is in read-only mode while we transition to the new forum.

    You can continue this topic on the new forum by tapping the "Continue discussion" link below.

Please Sign in or register to post replies